From 8f046f245fadd8dc7efdbd6c29adf07ca327836a Mon Sep 17 00:00:00 2001
From: pacien
Date: Sat, 1 Apr 2023 19:43:47 +0200
Subject: app: do no prevent encrypted or local backups

Backup was disabled altogether to avoid leaking the private keys in
clear.

This relaxes this restriction only for client-side encrypted online
backups or local device-to-device transfers.
---
 app/src/main/AndroidManifest.xml               |  7 +++--
 app/src/main/res/xml/backup_rules.xml          | 39 ++++++++++++++++++++++++
 app/src/main/res/xml/data_extraction_rules.xml | 41 ++++++++++++++++++++++++++
 3 files changed, 85 insertions(+), 2 deletions(-)
 create mode 100644 app/src/main/res/xml/backup_rules.xml
 create mode 100644 app/src/main/res/xml/data_extraction_rules.xml

diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index 4afbf32..f3b35b6 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -31,12 +31,15 @@
 
     <application
         android:name="org.pacien.tincapp.context.App"
-        android:allowBackup="false"
+        android:allowBackup="true"
+        android:dataExtractionRules="@xml/data_extraction_rules"
+        android:fullBackupContent="@xml/backup_rules"
         android:icon="@mipmap/ic_launcher"
         android:label="@string/app_name"
         android:supportsRtl="true"
         android:theme="@style/AppTheme"
-        tools:ignore="GoogleAppIndexingWarning">
+        tools:ignore="GoogleAppIndexingWarning"
+        tools:targetApi="s">
 
         <uses-library
             android:name="org.apache.http.legacy"
diff --git a/app/src/main/res/xml/backup_rules.xml b/app/src/main/res/xml/backup_rules.xml
new file mode 100644
index 0000000..6217761
--- /dev/null
+++ b/app/src/main/res/xml/backup_rules.xml
@@ -0,0 +1,39 @@
+<?xml version="1.0" encoding="utf-8"?>
+
+<!--
+ * Tinc App, an Android binding and user interface for the tinc mesh VPN daemon
+ * Copyright (C) 2017-2023 Pacien TRAN-GIRARD
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+-->
+
+<full-backup-content>
+    <include
+        domain="file"
+        path="./"
+        requireFlags="clientSideEncryption" />
+    <include
+        domain="file"
+        path="./"
+        requireFlags="deviceToDeviceTransfer" />
+
+    <include
+        domain="external"
+        path="./"
+        requireFlags="clientSideEncryption" />
+    <include
+        domain="external"
+        path="./"
+        requireFlags="deviceToDeviceTransfer" />
+</full-backup-content>
\ No newline at end of file
diff --git a/app/src/main/res/xml/data_extraction_rules.xml b/app/src/main/res/xml/data_extraction_rules.xml
new file mode 100644
index 0000000..40e5341
--- /dev/null
+++ b/app/src/main/res/xml/data_extraction_rules.xml
@@ -0,0 +1,41 @@
+<?xml version="1.0" encoding="utf-8"?>
+
+<!--
+ * Tinc App, an Android binding and user interface for the tinc mesh VPN daemon
+ * Copyright (C) 2017-2023 Pacien TRAN-GIRARD
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+-->
+
+<data-extraction-rules>
+
+    <cloud-backup disableIfNoEncryptionCapabilities="true">
+        <include
+            domain="file"
+            path="./" />
+        <include
+            domain="external"
+            path="./" />
+    </cloud-backup>
+
+    <device-transfer>
+        <include
+            domain="file"
+            path="./" />
+        <include
+            domain="external"
+            path="./" />
+    </device-transfer>
+
+</data-extraction-rules>
\ No newline at end of file
-- 
cgit v1.2.3