From 8b44284c7fae76e7e402387500acab7b64a7dad3 Mon Sep 17 00:00:00 2001
From: pacien
Date: Tue, 21 Aug 2018 22:39:07 +0200
Subject: Remove side gutters on large screens

---
 .../org/pacien/tincapp/activities/BaseActivity.kt  | 20 ++++++----
 .../activities/configure/ConfigureActivity.kt      |  3 +-
 .../tincapp/activities/start/ConnectionStarter.kt  |  4 +-
 .../activities/status/nodes/NodeListFragment.kt    |  4 +-
 .../tincapp/activities/viewlog/ViewLogActivity.kt  |  3 +-
 app/src/main/res/layout/base.xml                   | 43 ----------------------
 app/src/main/res/layout/base_activity.xml          | 25 +++++++++++++
 app/src/main/res/values-w960dp/dimens.xml          | 23 ------------
 app/src/main/res/values/dimens.xml                 |  1 -
 9 files changed, 44 insertions(+), 82 deletions(-)
 delete mode 100644 app/src/main/res/layout/base.xml
 create mode 100644 app/src/main/res/layout/base_activity.xml
 delete mode 100644 app/src/main/res/values-w960dp/dimens.xml

(limited to 'app')

diff --git a/app/src/main/java/org/pacien/tincapp/activities/BaseActivity.kt b/app/src/main/java/org/pacien/tincapp/activities/BaseActivity.kt
index a51d401..d9d549b 100644
--- a/app/src/main/java/org/pacien/tincapp/activities/BaseActivity.kt
+++ b/app/src/main/java/org/pacien/tincapp/activities/BaseActivity.kt
@@ -26,7 +26,7 @@ import android.support.design.widget.Snackbar
 import android.support.v7.app.AlertDialog
 import android.support.v7.app.AppCompatActivity
 import android.view.*
-import kotlinx.android.synthetic.main.base.*
+import kotlinx.android.synthetic.main.base_activity.*
 import org.pacien.tincapp.R
 import org.pacien.tincapp.context.App
 import org.pacien.tincapp.context.AppInfo
@@ -37,11 +37,12 @@ import org.pacien.tincapp.context.CrashRecorder
  * @author pacien
  */
 abstract class BaseActivity : AppCompatActivity() {
+  private val rootView by lazy { base_activity_frame!! }
   private var active = false
 
   override fun onCreate(savedInstanceState: Bundle?) {
     super.onCreate(savedInstanceState)
-    setContentView(R.layout.base)
+    super.setContentView(R.layout.base_activity)
   }
 
   override fun onCreateOptionsMenu(m: Menu): Boolean {
@@ -69,6 +70,10 @@ abstract class BaseActivity : AppCompatActivity() {
     super.onStop()
   }
 
+  override fun setContentView(layoutResID: Int) {
+    layoutInflater.inflate(layoutResID, rootView)
+  }
+
   override fun getSupportActionBar() = super.getSupportActionBar()!!
 
   fun startActivityChooser(target: Intent, title: String) {
@@ -76,7 +81,8 @@ abstract class BaseActivity : AppCompatActivity() {
     startActivity(intentChooser)
   }
 
-  fun aboutDialog(@Suppress("UNUSED_PARAMETER") i: MenuItem) {
+  @Suppress("UNUSED_PARAMETER")
+  fun aboutDialog(m: MenuItem) {
     AlertDialog.Builder(this)
       .setTitle(resources.getString(R.string.app_name))
       .setMessage(resources.getString(R.string.app_short_desc) + "\n\n" +
@@ -112,11 +118,11 @@ abstract class BaseActivity : AppCompatActivity() {
       .show()
   }
 
-  fun inflate(@LayoutRes layout: Int) = layoutInflater.inflate(layout, main_content, false)!!
-  fun inflate(inflateFunc: (LayoutInflater, ViewGroup, Boolean) -> View) = inflateFunc(layoutInflater, main_content, false)
+  fun inflate(@LayoutRes layout: Int) = layoutInflater.inflate(layout, rootView, false)!!
+  fun inflate(inflateFunc: (LayoutInflater, ViewGroup?, Boolean) -> View) = inflateFunc(layoutInflater, rootView, false)
 
-  fun notify(@StringRes msg: Int) = Snackbar.make(activity_base, msg, Snackbar.LENGTH_LONG).show()
-  fun notify(msg: String) = Snackbar.make(activity_base, msg, Snackbar.LENGTH_LONG).show()
+  fun notify(@StringRes msg: Int) = Snackbar.make(base_activity_frame, msg, Snackbar.LENGTH_LONG).show()
+  fun notify(msg: String) = Snackbar.make(base_activity_frame, msg, Snackbar.LENGTH_LONG).show()
 
   fun showErrorDialog(msg: String): AlertDialog = AlertDialog.Builder(this)
     .setTitle(R.string.title_error).setMessage(msg)
diff --git a/app/src/main/java/org/pacien/tincapp/activities/configure/ConfigureActivity.kt b/app/src/main/java/org/pacien/tincapp/activities/configure/ConfigureActivity.kt
index 9c9be70..c215f70 100644
--- a/app/src/main/java/org/pacien/tincapp/activities/configure/ConfigureActivity.kt
+++ b/app/src/main/java/org/pacien/tincapp/activities/configure/ConfigureActivity.kt
@@ -19,7 +19,6 @@
 package org.pacien.tincapp.activities.configure
 
 import android.os.Bundle
-import kotlinx.android.synthetic.main.base.*
 import org.pacien.tincapp.R
 import org.pacien.tincapp.activities.BaseActivity
 
@@ -30,6 +29,6 @@ class ConfigureActivity : BaseActivity() {
   override fun onCreate(savedInstanceState: Bundle?) {
     super.onCreate(savedInstanceState)
     supportActionBar.setDisplayHomeAsUpEnabled(true)
-    layoutInflater.inflate(R.layout.configure_activity, main_content)
+    setContentView(R.layout.configure_activity)
   }
 }
diff --git a/app/src/main/java/org/pacien/tincapp/activities/start/ConnectionStarter.kt b/app/src/main/java/org/pacien/tincapp/activities/start/ConnectionStarter.kt
index 9e7e59d..06046e9 100644
--- a/app/src/main/java/org/pacien/tincapp/activities/start/ConnectionStarter.kt
+++ b/app/src/main/java/org/pacien/tincapp/activities/start/ConnectionStarter.kt
@@ -20,7 +20,7 @@ package org.pacien.tincapp.activities.start
 
 import android.net.VpnService
 import android.support.v7.app.AlertDialog
-import kotlinx.android.synthetic.main.base.*
+import kotlinx.android.synthetic.main.base_activity.*
 import kotlinx.android.synthetic.main.dialog_decrypt_keys.view.*
 import org.pacien.tincapp.R
 import org.pacien.tincapp.service.TincVpnService
@@ -52,7 +52,7 @@ class ConnectionStarter(private val parentActivity: StartActivity) {
   }
 
   private fun askForPassphrase() {
-    val dialogView = parentActivity.layoutInflater.inflate(R.layout.dialog_decrypt_keys, parentActivity.main_content, false)
+    val dialogView = parentActivity.layoutInflater.inflate(R.layout.dialog_decrypt_keys, parentActivity.base_activity_frame, false)
 
     AlertDialog.Builder(parentActivity)
       .setTitle(R.string.title_unlock_private_keys)
diff --git a/app/src/main/java/org/pacien/tincapp/activities/status/nodes/NodeListFragment.kt b/app/src/main/java/org/pacien/tincapp/activities/status/nodes/NodeListFragment.kt
index 1111de7..cf1c1bc 100644
--- a/app/src/main/java/org/pacien/tincapp/activities/status/nodes/NodeListFragment.kt
+++ b/app/src/main/java/org/pacien/tincapp/activities/status/nodes/NodeListFragment.kt
@@ -26,7 +26,7 @@ import android.support.v7.app.AlertDialog
 import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
-import kotlinx.android.synthetic.main.base.*
+import kotlinx.android.synthetic.main.base_activity.*
 import kotlinx.android.synthetic.main.status_node_info_dialog.view.*
 import kotlinx.android.synthetic.main.status_node_list_fragment.*
 import org.pacien.tincapp.R
@@ -67,7 +67,7 @@ class NodeListFragment : Fragment() {
     showNodeInfo(nodeInfo.name)
 
   private fun showNodeInfo(nodeName: String) {
-    val dialogTextView = layoutInflater.inflate(R.layout.status_node_info_dialog, main_content, false)
+    val dialogTextView = layoutInflater.inflate(R.layout.status_node_info_dialog, base_activity_frame, false)
 
     AlertDialog.Builder(context!!)
       .setTitle(R.string.status_node_info_dialog_title)
diff --git a/app/src/main/java/org/pacien/tincapp/activities/viewlog/ViewLogActivity.kt b/app/src/main/java/org/pacien/tincapp/activities/viewlog/ViewLogActivity.kt
index a4e2216..dfe6d1b 100644
--- a/app/src/main/java/org/pacien/tincapp/activities/viewlog/ViewLogActivity.kt
+++ b/app/src/main/java/org/pacien/tincapp/activities/viewlog/ViewLogActivity.kt
@@ -26,7 +26,6 @@ import android.view.Menu
 import android.view.MenuItem
 import android.view.View
 import android.widget.ScrollView
-import kotlinx.android.synthetic.main.base.*
 import kotlinx.android.synthetic.main.view_log_activity.*
 import org.pacien.tincapp.R
 import org.pacien.tincapp.activities.BaseActivity
@@ -42,7 +41,7 @@ class ViewLogActivity : BaseActivity() {
   override fun onCreate(savedInstanceState: Bundle?) {
     super.onCreate(savedInstanceState)
     supportActionBar.setDisplayHomeAsUpEnabled(true)
-    layoutInflater.inflate(R.layout.view_log_activity, main_content)
+    setContentView(R.layout.view_log_activity)
     enableLogging(viewModel.logging)
   }
 
diff --git a/app/src/main/res/layout/base.xml b/app/src/main/res/layout/base.xml
deleted file mode 100644
index 96dff5d..0000000
--- a/app/src/main/res/layout/base.xml
+++ /dev/null
@@ -1,43 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-
-<!--
- * Tinc App, an Android binding and user interface for the tinc mesh VPN daemon
- * Copyright (C) 2017-2018 Pacien TRAN-GIRARD
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <https://www.gnu.org/licenses/>.
--->
-
-<android.support.design.widget.CoordinatorLayout xmlns:android="http://schemas.android.com/apk/res/android"
-																								 xmlns:app="http://schemas.android.com/apk/res-auto"
-																								 xmlns:tools="http://schemas.android.com/tools"
-																								 android:id="@+id/activity_base"
-																								 android:layout_width="match_parent"
-																								 android:layout_height="match_parent"
-																								 android:background="@color/backgroundSecondary"
-																								 android:clipToPadding="false"
-																								 android:fitsSystemWindows="true"
-																								 android:paddingLeft="@dimen/activity_horizontal_gutter"
-																								 android:paddingRight="@dimen/activity_horizontal_gutter"
-																								 app:layout_behavior="@string/appbar_scrolling_view_behavior"
-																								 tools:context=".activities.BaseActivity">
-
-	<FrameLayout
-		android:id="@+id/main_content"
-		android:layout_width="match_parent"
-		android:layout_height="match_parent"
-		android:background="@color/backgroundPrimary"
-		android:elevation="@dimen/activity_page_elevation">
-	</FrameLayout>
-
-</android.support.design.widget.CoordinatorLayout>
diff --git a/app/src/main/res/layout/base_activity.xml b/app/src/main/res/layout/base_activity.xml
new file mode 100644
index 0000000..e61fea4
--- /dev/null
+++ b/app/src/main/res/layout/base_activity.xml
@@ -0,0 +1,25 @@
+<?xml version="1.0" encoding="utf-8"?>
+
+<!--
+ * Tinc App, an Android binding and user interface for the tinc mesh VPN daemon
+ * Copyright (C) 2017-2018 Pacien TRAN-GIRARD
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+-->
+
+<android.support.design.widget.CoordinatorLayout
+	xmlns:android="http://schemas.android.com/apk/res/android"
+	android:id="@+id/base_activity_frame"
+	android:layout_width="match_parent"
+	android:layout_height="match_parent"/>
diff --git a/app/src/main/res/values-w960dp/dimens.xml b/app/src/main/res/values-w960dp/dimens.xml
deleted file mode 100644
index 959363b..0000000
--- a/app/src/main/res/values-w960dp/dimens.xml
+++ /dev/null
@@ -1,23 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-
-<!--
- * Tinc App, an Android binding and user interface for the tinc mesh VPN daemon
- * Copyright (C) 2017-2018 Pacien TRAN-GIRARD
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <https://www.gnu.org/licenses/>.
--->
-
-<resources>
-	<dimen name="activity_horizontal_gutter">64dp</dimen>
-</resources>
diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
index 5eb59e2..a514b9a 100644
--- a/app/src/main/res/values/dimens.xml
+++ b/app/src/main/res/values/dimens.xml
@@ -20,7 +20,6 @@
 
 <resources>
 	<!-- Default screen margins, per the Android Design guidelines. -->
-	<dimen name="activity_horizontal_gutter">0dp</dimen>
 	<dimen name="activity_horizontal_margin">16dp</dimen>
 	<dimen name="activity_vertical_margin">16dp</dimen>
 	<dimen name="activity_page_elevation">2dp</dimen>
-- 
cgit v1.2.3