diff options
author | pacien | 2024-01-20 00:20:12 +0100 |
---|---|---|
committer | pacien | 2024-01-20 00:20:12 +0100 |
commit | 94f3a07b20019a7d412bb1b5caa4f5ce153732a9 (patch) | |
tree | d27823422dad159b9a57c064b28ca64d1af1cf78 /app/src/main/java/org/pacien/tincapp/activities | |
parent | b5fe5e49e0d3cc2b7c53af23b7a4e7d3c4491be1 (diff) | |
download | tincapp-94f3a07b20019a7d412bb1b5caa4f5ce153732a9.tar.gz |
config: make all generated files accessible to the user
Permissions mode 0600 was preventing even the user from accessing the
configuration files. This makes the permissions more open.
The private key files should nevertheless be protected from other apps
by the permissions on the parent directory. Password protection for the
private key is also recommended in general.
GitHub: fixes #122
Diffstat (limited to 'app/src/main/java/org/pacien/tincapp/activities')
2 files changed, 9 insertions, 3 deletions
diff --git a/app/src/main/java/org/pacien/tincapp/activities/configure/tools/GenerateConfigToolDialogFragment.kt b/app/src/main/java/org/pacien/tincapp/activities/configure/tools/GenerateConfigToolDialogFragment.kt index 96e39ba..c152d54 100644 --- a/app/src/main/java/org/pacien/tincapp/activities/configure/tools/GenerateConfigToolDialogFragment.kt +++ b/app/src/main/java/org/pacien/tincapp/activities/configure/tools/GenerateConfigToolDialogFragment.kt | |||
@@ -1,6 +1,6 @@ | |||
1 | /* | 1 | /* |
2 | * Tinc App, an Android binding and user interface for the tinc mesh VPN daemon | 2 | * Tinc App, an Android binding and user interface for the tinc mesh VPN daemon |
3 | * Copyright (C) 2017-2018 Pacien TRAN-GIRARD | 3 | * Copyright (C) 2017-2024 Pacien TRAN-GIRARD |
4 | * | 4 | * |
5 | * This program is free software: you can redistribute it and/or modify | 5 | * This program is free software: you can redistribute it and/or modify |
6 | * it under the terms of the GNU General Public License as published by | 6 | * it under the terms of the GNU General Public License as published by |
@@ -23,6 +23,8 @@ import kotlinx.android.synthetic.main.configure_tools_dialog_network_generate.vi | |||
23 | import org.pacien.tincapp.R | 23 | import org.pacien.tincapp.R |
24 | import org.pacien.tincapp.commands.Tinc | 24 | import org.pacien.tincapp.commands.Tinc |
25 | import org.pacien.tincapp.commands.TincApp | 25 | import org.pacien.tincapp.commands.TincApp |
26 | import org.pacien.tincapp.context.AppPaths | ||
27 | import org.pacien.tincapp.utils.makePublic | ||
26 | 28 | ||
27 | /** | 29 | /** |
28 | * @author pacien | 30 | * @author pacien |
@@ -47,5 +49,6 @@ class GenerateConfigToolDialogFragment : ConfigurationToolDialogFragment() { | |||
47 | .thenCompose { Tinc.init(netName, nodeName) } | 49 | .thenCompose { Tinc.init(netName, nodeName) } |
48 | .thenCompose { TincApp.removeScripts(netName) } | 50 | .thenCompose { TincApp.removeScripts(netName) } |
49 | .thenCompose { TincApp.generateIfaceCfgTemplate(netName) } | 51 | .thenCompose { TincApp.generateIfaceCfgTemplate(netName) } |
50 | .thenCompose { TincApp.setPassphrase(netName, newPassphrase = passphrase) }) | 52 | .thenCompose { TincApp.setPassphrase(netName, newPassphrase = passphrase) } |
53 | .thenApply { AppPaths.confDir(netName).makePublic() }) | ||
51 | } | 54 | } |
diff --git a/app/src/main/java/org/pacien/tincapp/activities/configure/tools/JoinNetworkToolDialogFragment.kt b/app/src/main/java/org/pacien/tincapp/activities/configure/tools/JoinNetworkToolDialogFragment.kt index 25bdb15..f00b961 100644 --- a/app/src/main/java/org/pacien/tincapp/activities/configure/tools/JoinNetworkToolDialogFragment.kt +++ b/app/src/main/java/org/pacien/tincapp/activities/configure/tools/JoinNetworkToolDialogFragment.kt | |||
@@ -1,6 +1,6 @@ | |||
1 | /* | 1 | /* |
2 | * Tinc App, an Android binding and user interface for the tinc mesh VPN daemon | 2 | * Tinc App, an Android binding and user interface for the tinc mesh VPN daemon |
3 | * Copyright (C) 2017-2018 Pacien TRAN-GIRARD | 3 | * Copyright (C) 2017-2024 Pacien TRAN-GIRARD |
4 | * | 4 | * |
5 | * This program is free software: you can redistribute it and/or modify | 5 | * This program is free software: you can redistribute it and/or modify |
6 | * it under the terms of the GNU General Public License as published by | 6 | * it under the terms of the GNU General Public License as published by |
@@ -27,7 +27,9 @@ import kotlinx.android.synthetic.main.configure_tools_dialog_network_join.view.* | |||
27 | import org.pacien.tincapp.R | 27 | import org.pacien.tincapp.R |
28 | import org.pacien.tincapp.commands.Tinc | 28 | import org.pacien.tincapp.commands.Tinc |
29 | import org.pacien.tincapp.commands.TincApp | 29 | import org.pacien.tincapp.commands.TincApp |
30 | import org.pacien.tincapp.context.AppPaths | ||
30 | import org.pacien.tincapp.databinding.ConfigureToolsDialogNetworkJoinBinding | 31 | import org.pacien.tincapp.databinding.ConfigureToolsDialogNetworkJoinBinding |
32 | import org.pacien.tincapp.utils.makePublic | ||
31 | 33 | ||
32 | /** | 34 | /** |
33 | * @author pacien | 35 | * @author pacien |
@@ -78,5 +80,6 @@ class JoinNetworkToolDialogFragment : ConfigurationToolDialogFragment() { | |||
78 | .thenCompose { TincApp.removeScripts(netName) } | 80 | .thenCompose { TincApp.removeScripts(netName) } |
79 | .thenCompose { TincApp.generateIfaceCfg(netName) } | 81 | .thenCompose { TincApp.generateIfaceCfg(netName) } |
80 | .thenCompose { TincApp.setPassphrase(netName, newPassphrase = passphrase) } | 82 | .thenCompose { TincApp.setPassphrase(netName, newPassphrase = passphrase) } |
83 | .thenApply { AppPaths.confDir(netName).makePublic() } | ||
81 | ) | 84 | ) |
82 | } | 85 | } |