37 files changed, 694 insertions, 171 deletions

diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index c86ec8f..a1183d5 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -2,7 +2,7 @@
 
 <!--
  * Tinc App, an Android binding and user interface for the tinc mesh VPN daemon
- * Copyright (C) 2017-2020 Pacien TRAN-GIRARD
+ * Copyright (C) 2017-2023 Pacien TRAN-GIRARD
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -19,8 +19,7 @@
 -->
 
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    xmlns:tools="http://schemas.android.com/tools"
-    package="org.pacien.tincapp">
+    xmlns:tools="http://schemas.android.com/tools">
 
     <uses-permission android:name="android.permission.INTERNET" />
 
@@ -29,12 +28,15 @@
 
     <application
         android:name="org.pacien.tincapp.context.App"
-        android:allowBackup="false"
+        android:allowBackup="true"
+        android:dataExtractionRules="@xml/data_extraction_rules"
+        android:fullBackupContent="@xml/backup_rules"
         android:icon="@mipmap/ic_launcher"
         android:label="@string/app_name"
         android:supportsRtl="true"
         android:theme="@style/AppTheme"
-        tools:ignore="GoogleAppIndexingWarning">
+        tools:ignore="GoogleAppIndexingWarning"
+        tools:targetApi="s">
 
         <uses-library
             android:name="org.apache.http.legacy"
@@ -43,7 +45,7 @@
         <activity
             android:name=".activities.start.StartActivity"
             android:configChanges="orientation|screenSize"
-            android:label="@string/app_name">
+            android:exported="true">
             <intent-filter>
                 <action android:name="android.intent.action.MAIN" />
                 <category android:name="android.intent.category.LAUNCHER" />
@@ -62,7 +64,8 @@
 
         <activity
             android:name=".activities.status.StatusActivity"
-            android:configChanges="orientation|screenSize">
+            android:configChanges="orientation|screenSize"
+            android:exported="true">
             <intent-filter>
                 <action android:name="org.pacien.tincapp.intent.action.DISCONNECT" />
                 <category android:name="android.intent.category.DEFAULT" />
@@ -75,7 +78,8 @@
 
         <service
             android:name="org.pacien.tincapp.service.TincVpnService"
-            android:permission="android.permission.BIND_VPN_SERVICE">
+            android:permission="android.permission.BIND_VPN_SERVICE"
+            android:exported="true">
             <intent-filter>
                 <action android:name="android.net.VpnService" />
             </intent-filter>
diff --git a/app/src/main/c/0001-tincctl-restrict-umask-argument-for-FORTIFY.patch b/app/src/main/c/0001-tincctl-restrict-umask-argument-for-FORTIFY.patch
deleted file mode 100644
index 85ab949..0000000
--- a/app/src/main/c/0001-tincctl-restrict-umask-argument-for-FORTIFY.patch
+++ /dev/null
@@ -1,31 +0,0 @@
-From b6498e6402d9681743b697c1c9f0760448b3be54 Mon Sep 17 00:00:00 2001
-From: pacien <pacien.trangirard@pacien.net>
-Date: Wed, 9 Sep 2020 01:24:28 +0200
-Subject: [PATCH] tincctl: restrict umask argument for FORTIFY
-
-`umask(mode)` calls that do not verify `(mode & 0777) == mode` are
-rejected when the libc FORTIFY checks are enabled [1].
-
-The unrestricted `~perms` was indeed making this assertion fail.
-
-[1]: https://android.googlesource.com/platform/bionic/+/refs/tags/android-11.0.0_r3/libc/bionic/fortify.cpp#404
----
- src/tincctl.c | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/src/tincctl.c b/src/tincctl.c
-index 08f30189..11c1a96c 100644
---- a/src/tincctl.c
-+++ b/src/tincctl.c
-@@ -237,7 +237,7 @@ static bool parse_options(int argc, char **argv) {
- FILE *fopenmask(const char *filename, const char *mode, mode_t perms) {
-        mode_t mask = umask(0);
-        perms &= ~mask;
--       umask(~perms);
-+       umask(~perms & 0777);
-        FILE *f = fopen(filename, mode);
- 
-        if(!f) {
--- 
-2.25.4
-
diff --git a/app/src/main/java/org/pacien/tincapp/activities/configure/ToolsFragment.kt b/app/src/main/java/org/pacien/tincapp/activities/configure/ToolsFragment.kt
index 9d30bee..5850a1c 100644
--- a/app/src/main/java/org/pacien/tincapp/activities/configure/ToolsFragment.kt
+++ b/app/src/main/java/org/pacien/tincapp/activities/configure/ToolsFragment.kt
@@ -1,6 +1,6 @@
 /*
  * Tinc App, an Android binding and user interface for the tinc mesh VPN daemon
- * Copyright (C) 2017-2020 Pacien TRAN-GIRARD
+ * Copyright (C) 2017-2023 Pacien TRAN-GIRARD
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -46,5 +46,5 @@ class ToolsFragment : BaseFragment() {
   }
 
   private fun openDialog(tool: ConfigurationToolDialogFragment): () -> Unit =
-    { tool.show(fragmentManager, tool.javaClass.simpleName) }
+    { if (!tool.isAdded) tool.show(fragmentManager!!, tool.javaClass.simpleName) }
 }
diff --git a/app/src/main/java/org/pacien/tincapp/activities/configure/tools/GenerateConfigToolDialogFragment.kt b/app/src/main/java/org/pacien/tincapp/activities/configure/tools/GenerateConfigToolDialogFragment.kt
index 96e39ba..c152d54 100644
--- a/app/src/main/java/org/pacien/tincapp/activities/configure/tools/GenerateConfigToolDialogFragment.kt
+++ b/app/src/main/java/org/pacien/tincapp/activities/configure/tools/GenerateConfigToolDialogFragment.kt
@@ -1,6 +1,6 @@
 /*
  * Tinc App, an Android binding and user interface for the tinc mesh VPN daemon
- * Copyright (C) 2017-2018 Pacien TRAN-GIRARD
+ * Copyright (C) 2017-2024 Pacien TRAN-GIRARD
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -23,6 +23,8 @@ import kotlinx.android.synthetic.main.configure_tools_dialog_network_generate.vi
 import org.pacien.tincapp.R
 import org.pacien.tincapp.commands.Tinc
 import org.pacien.tincapp.commands.TincApp